Style fixes for pinned messages #18061

alwx · 2023-12-04T11:02:37Z

Updates the visual style of pinned messages so they now match the designs.

fixes #17523
fixes #17524
fixes #17527

Platforms

Android
iOS

Functional

1-1 chats
public chats
group chats

status: ready

status-im-auto · 2023-12-04T11:10:11Z

Jenkins Builds

Click to see older builds (4)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`2d65bc5`	#2	2023-12-04 11:10:11	~6 min	`ios`	📱`ipa` 📲
✔️	`2d65bc5`	#2	2023-12-04 11:11:08	~7 min	`android-e2e`	🤖`apk` 📲
✔️	`2d65bc5`	#2	2023-12-04 11:12:18	~8 min	`android`	🤖`apk` 📲
✔️	`2d65bc5`	#2	2023-12-04 11:14:35	~11 min	`tests`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`2347b5c`	#3	2023-12-04 15:58:15	~6 min	`android`	🤖`apk` 📲
✔️	`2347b5c`	#3	2023-12-04 15:58:47	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`2347b5c`	#3	2023-12-04 16:05:11	~13 min	`ios`	📱`ipa` 📲

✔️	`822f93b`	#4	2023-12-05 08:50:31	~6 min	`android-e2e`	🤖`apk` 📲
✔️	`822f93b`	#4	2023-12-05 08:50:46	~6 min	`android`	🤖`apk` 📲
✔️	`822f93b`	#4	2023-12-05 08:51:11	~6 min	`ios`	📱`ipa` 📲
✔️	`822f93b`	#4	2023-12-05 08:56:05	~11 min	`tests`	📄`log`

status-im-auto · 2023-12-04T13:00:27Z

77% of end-end tests have passed

Total executed tests: 48
Failed tests: 6
Expected to fail tests: 5
Passed tests: 37

IDs of failed tests: 702809,703133,703496,702786,702846,703629

IDs of expected to fail tests: 702732,702783,703503,702731,702808

Failed tests (6)

Click to expand

Rerun failed tests

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_mute_chat, id: 703496

Device 1: Click until `ChatMessageInput` by `accessibility id`: `chat-message-input` will be presented
Device 1: Looking for a message by text: after unmute

critical/chats/test_1_1_public_chats.py:661: in test_1_1_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Message text 'should be muted' is not shown in chat preview after mute
E    Message 'should be muted' is not shown in chat for receiver after mute
E    New messages counter is not shown after unmute
E    Message text 'after unmute' is not shown in chat preview after unmute
E    Message 'after unmute' is not shown in chat for receiver after unmute

Device sessions

Device 1:

Device 2:

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
# STEP: Checking that "bold text in asterics" is applied () in community channel Device 2: Sending message 'bold text in asterics**' critical/chats/test_public_chat_browsing.py:924: in test_community_markdown_support self.channel_2.send_message(message_to_send) ../views/chat_view.py:1003: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:121: in wait_for_element raise TimeoutException( Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_mentions_push_notification, id: 702786
# STEP: Invited member sends a message with a mention Device 2: Sending message 'hi' critical/chats/test_public_chat_browsing.py:820: in test_community_mentions_push_notification self.channel_2.send_message("hi") ../views/chat_view.py:1003: in send_message self.chat_message_input.wait_for_element(wait_chat_input_sec) ../views/base_element.py:121: in wait_for_element raise TimeoutException( Device `2`: `ChatMessageInput` by` accessibility id`: `chat-message-input` is not found on the screen after wait_for_element Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_community_join_when_node_owner_offline, id: 703629
Device 2: Looking for community: 'open community' Device 2: Click until `Text` by `accessibility id`: `community-description-text` will be presented `critical/chats/test_public_chat_browsing.py:1112: in test_community_join_when_node_owner_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Text "You joined “closed community”" in shown toast element doesn't match expected "You joined “open community”"` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device 1: Find `Button` by `accessibility id`: `show-profiles` Device 1: Tap on found: Button `critical/chats/test_public_chat_browsing.py:273: in test_restore_multiaccount_with_waku_backup_remove_switch self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Incorrect contacts number restored: 3 instead of 2` Device sessions Device 1: Steps, video, logs Failure screenshot
2. test_community_navigate_to_channel_when_relaunch, id: 702846
## Signed in successfully! Device 1: Looking for a message by text: some_text `critical/chats/test_public_chat_browsing.py:83: in test_community_navigate_to_channel_when_relaunch self.drivers[0].fail("Not navigated to channel view after reopening app") base_test_case.py:179: in fail pytest.fail('Device %s: %s' % (self.number, text)) Device 1: Not navigated to channel view after reopening app` Device sessions Device 1: Steps, video, logs Failure screenshot

Expected to fail tests (5)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]
2. test_group_chat_offline_pn, id: 702808
Device 3: Looking for a message by text: message from old member Device 3: Looking for a message by text: message from new member `critical/chats/test_group_chat.py:323: in test_group_chat_offline_pn self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Messages PN was not fetched from offline` [[Data delivery issue]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot Device 3: Steps, video, logs Failure screenshot

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_pin_messages, id: 702731
`Test is not run, e2e blocker` [[reason: [NOTRUN] Pin feature is in development]]

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device 2: Find `Text` by `xpath`: `//[starts-with(@text,'test message')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//[@content-desc='message-status']/android.widget.TextView` Device 2: `Text` is `Sent` `critical/chats/test_1_1_public_chats.py:620: in test_1_1_chat_is_shown_message_sent_delivered_from_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Message was not delivered after resending from offline E Message status was not changed to Delivered, it's Sent after back up online!` [[Data delivery issue]] Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (37)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_join_send_text_messages_push, id: 702807
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device sessions Device 1: Steps, video, logs
2. test_links_open_universal_links_from_other_apps, id: 704614
Device sessions Device 1: Steps, video, logs
3. test_links_deep_links, id: 702775
Device sessions Device 1: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
2. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
3. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

churik · 2023-12-04T15:06:06Z

@alwx I can't see the illustration for empty state of pinned messages:

alwx · 2023-12-04T15:51:31Z

@churik this PR doesn't update the illustration — there is a separate issue for it (#17522) and this issue remains unfixed (because there is no illustration yet)

status-im-auto · 2023-12-04T16:15:31Z

33% of end-end tests have passed

Total executed tests: 6
Failed tests: 4
Expected to fail tests: 0
Passed tests: 2

IDs of failed tests: 702786,703629,702809,703133

Failed tests (4)

Click to expand

Rerun failed tests

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133

Device 1: Find `Button` by `accessibility id`: `show-profiles`
Device 1: Tap on found: Button

critical/chats/test_public_chat_browsing.py:273: in test_restore_multiaccount_with_waku_backup_remove_switch
    self.errors.verify_no_errors()
base_test_case.py:191: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Incorrect contacts number restored: 3 instead of 2

Device sessions

Device 1:

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_mentions_push_notification, id: 702786
Device 2: Getting PN by 'user_2' Device 2: Looking for a message by text: user_2 `critical/chats/test_public_chat_browsing.py:901: in test_community_mentions_push_notification self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Can not edit a message with a mention E Edited message is not shown correctly for the (receiver) admin` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
2. test_community_join_when_node_owner_offline, id: 703629
Device 2: Tap on found: Button Device 2: Looking for community: 'open community' `critical/chats/test_public_chat_browsing.py:1112: in test_community_join_when_node_owner_offline self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Joined status is not displayed E open community is not listed inside Joined communities tab` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot
3. test_community_markdown_support, id: 702809
Device 1: Looking for a message by text: quote reply (one row) Device 2: Looking for a message by text: quote reply (one row) `critical/chats/test_public_chat_browsing.py:953: in test_community_markdown_support self.errors.verify_no_errors() base_test_case.py:191: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) bold text in underscores is not displayed with markdown in community channel for the recipient (device 1)` Device sessions Device 1: Steps, video, logs Failure screenshot Device 2: Steps, video, logs Failure screenshot

Passed tests (2)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

churik · 2023-12-04T16:52:26Z

@alwx ah, sorry, missed the description. Thank you!

churik · 2023-12-04T16:53:40Z

@Francesca-G please, review if PR fixes issues from design perspective, thank you!

Francesca-G

Looks good to me :)

* Style fixes for pinned messages * Small code style update

Style fixes for pinned messages

829aecb

alwx requested review from flexsurfer, ilmotta and ibrkhalil December 4, 2023 11:02

alwx self-assigned this Dec 4, 2023

Small code style update

2d65bc5

flexsurfer approved these changes Dec 4, 2023

View reviewed changes

ibrkhalil approved these changes Dec 4, 2023

View reviewed changes

churik added the request-manual-qa label Dec 4, 2023

churik self-assigned this Dec 4, 2023

ilmotta approved these changes Dec 4, 2023

View reviewed changes

Merge branch 'develop' into pinned-messages-style

2347b5c

churik added the Tested - OK label Dec 4, 2023

Merge branch 'develop' into pinned-messages-style

822f93b

Francesca-G approved these changes Dec 5, 2023

View reviewed changes

alwx merged commit a4f1f23 into develop Dec 5, 2023
6 checks passed

alwx deleted the pinned-messages-style branch December 5, 2023 10:31

yevh-berdnyk pushed a commit that referenced this pull request Dec 8, 2023

Style fixes for pinned messages (#18061)

582c484

* Style fixes for pinned messages * Small code style update

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Style fixes for pinned messages #18061

Style fixes for pinned messages #18061

alwx commented Dec 4, 2023

status-im-auto commented Dec 4, 2023 •

edited

Loading

status-im-auto commented Dec 4, 2023

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestCommunityOneDeviceMerged:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePRTwo:

Class TestDeepLinksOneDevice:

Class TestCommunityOneDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

churik commented Dec 4, 2023

alwx commented Dec 4, 2023 •

edited

Loading

status-im-auto commented Dec 4, 2023

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

churik commented Dec 4, 2023

churik commented Dec 4, 2023

Francesca-G left a comment

Style fixes for pinned messages #18061

Style fixes for pinned messages #18061

Conversation

alwx commented Dec 4, 2023

Platforms

Functional

status-im-auto commented Dec 4, 2023 • edited Loading

Jenkins Builds

status-im-auto commented Dec 4, 2023

77% of end-end tests have passed

Failed tests (6)

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestCommunityOneDeviceMerged:

Expected to fail tests (5)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestCommunityOneDeviceMerged:

Passed tests (37)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestActivityMultipleDevicePRTwo:

Class TestDeepLinksOneDevice:

Class TestCommunityOneDeviceMerged:

Class TestActivityMultipleDevicePR:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityCenterContactRequestMultipleDevicePR:

churik commented Dec 4, 2023

alwx commented Dec 4, 2023 • edited Loading

status-im-auto commented Dec 4, 2023

33% of end-end tests have passed

Failed tests (4)

Class TestCommunityOneDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Passed tests (2)

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

churik commented Dec 4, 2023

churik commented Dec 4, 2023

Francesca-G left a comment

Choose a reason for hiding this comment

status-im-auto commented Dec 4, 2023 •

edited

Loading

alwx commented Dec 4, 2023 •

edited

Loading